TF2M Migration Bugs

Pigzit

L69: Deviant Member
Aug 2, 2017
69
24
Description of bug: Attempting to get to "https://tf2maps.net/account/contact-details" after donating to connect to discord gives a missing page
Pictures of bug:
1657305212903.png

How to reproduce the bug: Go to "https://tf2maps.net/account/contact-details", happens when clicking the "Connect here!" link, and when pasting the URL
 

Pigzit

L69: Deviant Member
Aug 2, 2017
69
24
Where are you getting the link from? I think that got phased out in XF2.
Right after I donated, a popup came up in the bottom left that I can't seem to recreate after I closed it. It linked me to a thread that was about how to get your donator role in discord, and that thread told me to use that link to connect this account to my discord account
 

nesman

master of fast travel
aa
Jun 27, 2016
1,554
1,380
Right after I donated, a popup came up in the bottom left that I can't seem to recreate after I closed it. It linked me to a thread that was about how to get your donator role in discord, and that thread told me to use that link to connect this account to my discord account
Very old thread then. That was phased out with XF2.
 

Pocket

Half a Lambert is better than one.
aa
Nov 14, 2009
4,712
2,587
Not really a bug, but I'm kinda not on board with the main forum page being called "Forum List" in the window/tab title now. It feels way too generic and isn't really useful information. Would it be possible to change it back to whatever it used to be called?
 

Pocket

Half a Lambert is better than one.
aa
Nov 14, 2009
4,712
2,587
Also not a bug, more a design flaw in this version of Xenforo, but maybe there's a setting you can change to get it back to how it's supposed to be? You know how when you click on a thread you've been to before, it remembers what the last post is that you've already seen and automatically jumps you to the one after it? Now it will only remember for a few weeks; if I'm away long enough (or if the thread doesn't get updated often), it'll just default to showing me the first post.
 

DonutVikingChap

L5: Dapper Member
Mar 15, 2013
233
140
Description of bug:
The "downloads" counters on downloads that were uploaded before the migration show the same number as the "views" counter.

Pictures of bug:
tf2mbug1.png
tf2mbug2.png
tf2mbug3.png

The "views" stats on my own downloads seem roughly correct from what I can remember, but the downloads obviously weren't that high.

Downloads uploaded after the migration seem to work fine:
tf2mnobug1.png


How to reproduce the bug:
See the stats on the right of the following pages:
https://tf2maps.net/downloads/ascii-fortress-2.3816/
https://tf2maps.net/downloads/invasion.198/
https://tf2maps.net/downloads/pl_thermo.11177/
https://tf2maps.net/downloads/nepal.12686/
Just a reminder that this bug is still in effect. For example, ASCII Fortress 2 is currently at 1564 synchronized views/downloads, and pl_invasion is currently at 280. I'm pretty convinced that it is showing the view counter for both numbers, not the downloads, since I can't imagine 59 people suddenly deciding to download a 7 year old map that was never very popular, and there certainly hasn't been 340 people connecting to the ASCII Fortress 2 server browser since I posted this.
 

nesman

master of fast travel
aa
Jun 27, 2016
1,554
1,380
The old site didn't have a views counter so I guess the migration just set them to the same number?

Just a reminder that this bug is still in effect. For example, ASCII Fortress 2 is currently at 1564 synchronized views/downloads, and pl_invasion is currently at 280. I'm pretty convinced that it is showing the view counter for both numbers, not the downloads, since I can't imagine 59 people suddenly deciding to download a 7 year old map that was never very popular, and there certainly hasn't been 340 people connecting to the ASCII Fortress 2 server browser since I posted this.
we can't fix it
 

DonutVikingChap

L5: Dapper Member
Mar 15, 2013
233
140
we can't fix it
I am at least 90% sure that the old site did have a view counter, because I remember checking it on the ASCII Fortress 2 page every now and then before the migration. The supposed download counts that were transferred from the old site for the respective download pages right after the migration also seemed a bit too high for them to have made sense. I suspect that those numbers were actually taken from the previous view counts, and that the shown number of downloads is currently set to display the same number as the view counter for some reason.

Anyway, regardless of whether the old site had a view counter or not, the view and download numbers obviously shouldn't be synchronized as they currently are. To be clear, for each of the download pages I gave as examples in my first post, the view and download counters have both increased since then, and they are still exactly equal to each other. This is obviously not a coincidence, and the numbers are, again, way too high for it to make sense that they represent the number of downloads.

To summarize, one of the following must be true:
1. (Less likely) The old view counter accidentally overwrote the old download counter in the database and there is currently a problem somewhere causing the view counter to keep adding to the download counter.
2. (Very likely) For old download pages, there is a simple mistake in the page definition where the frontend fetches and prints the view counter for both numbers, which could probably be fixed by changing one line of PHP.
 
Last edited:

nesman

master of fast travel
aa
Jun 27, 2016
1,554
1,380
Again, we won't be able to fix it, it's been too long since the migration to even be able to fix it. If you really want to you are welcome to make a new download page to have accurate view counts. Modifying Xenforo code can and will have unintended consequences on other pages and because this is very minor it doesn't make sense to break other things.
 

DonutVikingChap

L5: Dapper Member
Mar 15, 2013
233
140
Again, we won't be able to fix it, it's been too long since the migration to even be able to fix it. If you really want to you are welcome to make a new download page to have accurate view counts. Modifying Xenforo code can and will have unintended consequences on other pages and because this is very minor it doesn't make sense to break other things.
I understand that changing code can have unintended consequences, and in some cases that can warrant delaying the fix for a short time until the most qualified person is available to do the job (although if you have a proper test environment set up, the risks of making such changes should really be minimal). In this case it should hopefully be a simple, local and isolated change that would both fix an obvious problem and improve the site for anybody looking at older downloads (of which there are a lot, besides just mine!). There is no reason not to fix it (or at least look into it).

Besides, what is the point of having a thread for reporting bugs if you weren't planning to fix any bugs? Have you really put yourselves in the situation where everyone responsible for the code has vanished from existence and you are now bound to the current state of the site until the next major migration? That would be very unfortunate for everyone involved. What will you do the next time something breaks? What if the entire database gets corrupted under your noses? What if the site gets hacked and account data gets stolen, etc. etc. Basically, there surely has to be someone responsible for making sure the site works on a basic level, such as displaying the right information and not silently corrupting stat counters in the background while most things seem to be working. If I were you I would actually prioritize this as something that needs to be checked as soon as possible to make sure there is not some serious underlying issue, which is partly why I reported it in the first place.