Attached screenshots should be embeds, not links

Pocket

Pocket

Half a Lambert is better than one.
aa
Nov 14, 2009
4,696
2,580
I know people don't pay as much attention to map threads as they used to now that the feedback plugin is a thing, but one thing that always kept them interesting — and helped me remember which of the 10 generically named [game mode] maps currently in rotation was which — was the addition of new screenshots every update or so. Right now, we have an even easier way to add those screenshots: Just upload them directly when you update the map and it'll make a new post for you. Except it doesn't actually display those screenshots inline; instead it's just a single line of text "View attachment XXXXX View attachment XXXXY View attachment XXXXZ"...

I see no reason why those can't be a stack of inline images instead. Can that be a thing? In fact, I'd like to see it applied retroactively, if there's a way that could happen.
 
Pocket

Pocket

Half a Lambert is better than one.
aa
Nov 14, 2009
4,696
2,580
Oh, and I'm not sure what benefit it has to truncate those posts either; for all I know, that's causing screenshots to not even show up as links most of the time because the description/patch notes exceed the arbitrary line limit.
 
Viemärirotta

Viemärirotta

sniffer
aa
Feb 5, 2016
1,013
590
I heavily agree on this, it's rather annoying when somebody wants to add screenshots on updates and it turns out to be a link on the discussion side. Even though video links work properly.
 
Geit

Geit

💜 I probably broke it 💜
aa
May 28, 2009
598
1,161
It's an annoying but intended feature of Xenforo, the basic idea is that it'll only appear as an embed on the original content item because otherwise you could simply spoof the [attach]x[/attach] tag (because x is always sequential) and access attachments you don't have the rights to view.

Placing it as a link forces Xenforo to check if you have permissions to view the original content item it was attached with before redirecting you to the actual image.

I'm not sure how to fix it short of rewriting Xenforo's attachment system, and there's no built in way to disable attachment security.
 
Viemärirotta

Viemärirotta

sniffer
aa
Feb 5, 2016
1,013
590
Geit said:
It's an annoying but intended feature of Xenforo, the basic idea is that it'll only appear as an embed on the original content item because otherwise you could simply spoof the [attach]x[/attach] tag (because x is always sequential) and access attachments you don't have the rights to view.

Placing it as a link forces Xenforo to check if you have permissions to view the original content item it was attached with before redirecting you to the actual image.

I'm not sure how to fix it short of rewriting Xenforo's attachment system, and there's no built in way to disable attachment security.
Click to expand...

Well that's slightly annoying, even though it's a intended feature.
 
Geit

Geit

💜 I probably broke it 💜
aa
May 28, 2009
598
1,161
Test

thumbs_DSC_1410_.JPG

thumbs_DSC_1410_.JPG
 
Last edited:
Geit

Geit

💜 I probably broke it 💜
aa
May 28, 2009
598
1,161



Shouldn't be viewable.
 
Last edited:
Zed

Zed

Certified Most Crunk™
aa
Aug 7, 2014
1,241
1,025
Of course that's the image that pops up when I open this thread as someone's walking by.
 
Geit

Geit

💜 I probably broke it 💜
aa
May 28, 2009
598
1,161
All fixed, I think.

using attachment thumbnails will add a bit of overhead to the page load time for the server as it has to do permission checks and whatnot, but I don't think it should be significant on most pages. (it adds about 0.01 seconds [10ms] to this thread)
 
You must log in or register to reply here.
Top Bottom