Does this lighting look right?

No the lighting seems fine, though that upper left silver tank looks a little too shiney.

Are you using the proper enviromental light ents? env_sun, light_env?

Env_sun doesn't actually cast light, btw. It just looks nice.

The lighting looks nice, but the displacements do not; start over and use a larger radius brush.

Fr0Z3n said:

No the lighting seems fine, though that upper left silver tank looks a little too shiney.

Click to expand...

I would agree with your statement

i'm not sure about the strong spotlights in areas already well lit (both outside and just inside windows/doorways). they don't make a lot of sense to me.. you should increase the lightmap scale on the brushes upon which the light falls, just to lose the hard edge (without losing the light itself), and make minor performance savings in the process. personally, i'd ditch those outside lamp props altogether.

and just run a smooth brush over the displacement. i look forward to seeing the map.

It looks fine, but I know what you're talking about with it looking just a little "off". I'd say the lighting looks a little uninteresting because almost everything is in direct sunlight. Try and put things in the scene / angle the sunlight so that more shadows get cast. Things like pulleys sticking out of the building's wall to cast shadows along it are great.

Also be sure to make the indoor lighting noticeably different from the outdoors (the shack in the foreground looks just as bright inside as it does out). It usually helps to make the interiors a little darker or with light tinted a different color.